• 0 Posts
  • 21 Comments
Joined 1 year ago
cake
Cake day: June 11th, 2023

help-circle











  • Unfortunately, sometimes they can’t determine reproduction steps because it’s rare to happen and required multiple things, or they just didn’t catch it. I definitely don’t blame them, at least not in a lot of cases.

    And sometimes logs or crash dump or whatever is all you need to figure out the bug anyway. In fact, ideally it should be more often than not.







  • This sadly sounds like one of the projects on my teamat the moment and it’s horrifying.

    One guy working on it, I’m really the only reviewer. Code is all stuff like this. Variables named j1 through j20, dozens and dozens of nearly identical functions with tons of brute force, copy-pasted code, etc. Works well enough but it’s just horrifying to try to read and review.

    Edit:. Just remembered, he had all these grouped functions passing (and sometimes returning) 60+ identical variables that didn’t need to be local because he refused to use class vars, etc.

    He’s gotten a lot better about this stuff in the last year though